pgsql: In pg_restore's dump_lo_buf(), work a little harder on error han

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: In pg_restore's dump_lo_buf(), work a little harder on error han

Tom Lane-2
In pg_restore's dump_lo_buf(), work a little harder on error handling.

Failure to write data to a large object during restore led to an ugly
and uninformative error message.  To add insult to injury, it then
fatal'd out, where other SQL-level errors usually result in pressing on.

Report the underlying error condition, rather than just giving not-very-
useful byte counts, and use warn_or_exit_horribly() so as to adhere to
pg_restore's general policy about whether to continue or not.

Also recognize that lo_write() returns int not size_t.

Per report from Justin Pryzby, though I didn't use his patch.
Given the lack of comparable complaints, I'm not sure this is
worth back-patching.

Discussion: https://postgr.es/m/20201018010232.GF9241@...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/929c69aa1970b3ae30bbb5a159b9dc530ec34d5c

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)