pgsql: Ipcrm -> ipcclean in error message:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Ipcrm -> ipcclean in error message:

Bruce Momjian-6
Log Message:
-----------
Ipcrm -> ipcclean in error message:

---------------------------------------------------------------------------

While playing around, I got the following error message:

--
FATAL:  pre-existing shared memory block (key 5432001, ID 90898435) is
still in use
HINT:  If you're sure there are no old server processes still running,
remove the shared memory block with the command "ipcrm", or just delete
the file "/home/hlinnaka/pgsql/data/postmaster.pid".
---

Thats normal because I used "kill -9 postmaster" to shut down.

The hint advises me to use "ipcrm", but there's the "ipcclean" script in
bin for just this purpose. The hint should probably advise to use
ipcclean.

The attached patch replaces all occurances of "ipcrm" with "ipcclean" in
src/backend/utils/init/miscinit.c and all the translations in
src/backend/po.

While reviewing the patch, I noticed a likely typo in hr.po. While I
don't
speak Croatian, the translation seems to advise to use the "icpm(1)"
command. I changed that to "ipcclean" too.

Heikki Linnakangas

Modified Files:
--------------
    pgsql/src/backend/utils/init:
        miscinit.c (r1.139 -> r1.140)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/init/miscinit.c.diff?r1=1.139&r2=1.140)

---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend
Reply | Threaded
Open this post in threaded view
|

Re: pgsql: Ipcrm -> ipcclean in error message:

Tom Lane-2
[hidden email] (Bruce Momjian) writes:
> Ipcrm -> ipcclean in error message:

Are you kidding?  ipcclean is an unportable, poorly-tested hack.

                        regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
    (send "unregister YourEmailAddressHere" to [hidden email])
Reply | Threaded
Open this post in threaded view
|

Re: pgsql: Ipcrm -> ipcclean in error message:

Bruce Momjian-2
Tom Lane wrote:
> [hidden email] (Bruce Momjian) writes:
> > Ipcrm -> ipcclean in error message:
>
> Are you kidding?  ipcclean is an unportable, poorly-tested hack.

No, I am not kidding.  Should we not be distributing it?  It seems
strange no to recommend a tool we distribute.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  [hidden email]               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

               http://www.postgresql.org/docs/faq
Reply | Threaded
Open this post in threaded view
|

Re: pgsql: Ipcrm -> ipcclean in error message:

Bruce Momjian-2
In reply to this post by Tom Lane-2
Tom Lane wrote:
> [hidden email] (Bruce Momjian) writes:
> > Ipcrm -> ipcclean in error message:
>
> Are you kidding?  ipcclean is an unportable, poorly-tested hack.

I updated the error message to mention ipcclean and ipcrm.  However, if
ipcclean is bad maybe we should move it to /contrib.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  [hidden email]               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to [hidden email]