pgsql: Make error logging in extended statistics more consistent

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Make error logging in extended statistics more consistent

Tomas Vondra-5
Make error logging in extended statistics more consistent

Most errors reported in extended statistics are internal issues, and so
should use elog(). The MCV list code was already following this rule, but
the functional dependencies and ndistinct coefficients were using a mix
of elog() and ereport(). Fix this by changing most places to elog(), with
the exception of input functions.

This is a mostly cosmetic change, it makes the life a little bit easier
for translators, as elog() messages are not translated. So backpatch to
PostgreSQL 10, where extended statistics were introduced.

Author: Tomas Vondra
Backpatch-through: 10 where extended statistics were added
Discussion: https://postgr.es/m/20190503154404.GA7478@...

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9c9a74cd3257324257ec016e800ce0a6d5af88c7

Modified Files
--------------
src/backend/statistics/dependencies.c |  4 +---
src/backend/statistics/mvdistinct.c   | 22 +++++++---------------
2 files changed, 8 insertions(+), 18 deletions(-)