pgsql: More message style fixes

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

pgsql: More message style fixes

Álvaro Herrera
More message style fixes

Discussion: https://postgr.es/m/20190515183005.GA26486@...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/75445c1515fffa581585f1b72e5b5314c1c395ce

Modified Files
--------------
src/backend/commands/copy.c             |  6 ++---
src/backend/commands/publicationcmds.c  |  2 +-
src/backend/commands/subscriptioncmds.c | 40 +++++++++++++++++++++------------
src/backend/commands/tablecmds.c        |  8 +++----
src/backend/parser/analyze.c            |  2 +-
src/backend/postmaster/postmaster.c     |  7 +++---
src/backend/replication/walsender.c     | 25 ++++++++++++---------
src/backend/utils/adt/jsonpath.c        |  3 ++-
src/backend/utils/adt/jsonpath_exec.c   |  2 +-
src/backend/utils/adt/jsonpath_scan.l   | 10 ++++-----
src/backend/utils/adt/pg_locale.c       | 10 +++++----
src/backend/utils/adt/regexp.c          | 14 ++++++++----
12 files changed, 78 insertions(+), 51 deletions(-)

Reply | Threaded
Open this post in threaded view
|

Re: pgsql: More message style fixes

Tom Lane-2
Alvaro Herrera <[hidden email]> writes:
> More message style fixes

The buildfarm thinks you forgot something.

                        regards, tom lane


Reply | Threaded
Open this post in threaded view
|

Re: pgsql: More message style fixes

Michael Paquier-2
On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote:
> Alvaro Herrera <[hidden email]> writes:
>> More message style fixes
>
> The buildfarm thinks you forgot something.

One contrib module is impacted, citext, because it uses regexes and it
has multiple expected outputs.  The attached brings back my build to
green.  Thoughts?

I got a bit annoyed when testing this morning, so I don't mind fixing
it myself.  And I still have some hours left today to look at extra
red animals if any.
--
Michael

fix-test-output.patch (10K) Download Attachment
signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: pgsql: More message style fixes

Tom Lane-2
Michael Paquier <[hidden email]> writes:
> On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote:
>> The buildfarm thinks you forgot something.

> One contrib module is impacted, citext, because it uses regexes and it
> has multiple expected outputs.  The attached brings back my build to
> green.  Thoughts?

Looks reasonable, but check if any of the other tests have alternative
expected-files that you need to fix too.

                        regards, tom lane


Reply | Threaded
Open this post in threaded view
|

Re: pgsql: More message style fixes

Michael Paquier-2
On Thu, May 16, 2019 at 08:22:25PM -0400, Tom Lane wrote:
> Looks reasonable, but check if any of the other tests have alternative
> expected-files that you need to fix too.

I am not noticing anything else.  And I have checked once before
sending the previous patch, and once again now.  If I have missed one,
well...  Sorry.
--
Michael

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: pgsql: More message style fixes

Alvaro Herrera-9
In reply to this post by Michael Paquier-2
On 2019-May-17, Michael Paquier wrote:

> On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote:
> > Alvaro Herrera <[hidden email]> writes:
> >> More message style fixes
> >
> > The buildfarm thinks you forgot something.
>
> One contrib module is impacted, citext, because it uses regexes and it
> has multiple expected outputs.  The attached brings back my build to
> green.  Thoughts?

Argh.  Apologies, sorry for fixing so quickly.

--
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Reply | Threaded
Open this post in threaded view
|

Re: pgsql: More message style fixes

Michael Paquier-2
On Thu, May 16, 2019 at 10:29:16PM -0400, Alvaro Herrera wrote:
> Argh.  Apologies, sorry for fixing so quickly.

No problem.  The buildfarm does not complain anymore after the patch,
so it looks that we are good.
--
Michael

signature.asc (849 bytes) Download Attachment