pgsql: Reduce the size of the fmgr_builtin_oid_index[] array.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Reduce the size of the fmgr_builtin_oid_index[] array.

Tom Lane-2
Reduce the size of the fmgr_builtin_oid_index[] array.

This index array was originally defined to have 10000 entries (ranging
up to FirstGenbkiObjectId), but we really only need entries up to the
last existing builtin function OID, currently 6121.  That saves close
to 8K of never-accessed space in the server executable, at the small
price of one more fetch in fmgr_isbuiltin().

We could reduce the array size still further by renumbering a few of
the highest-numbered builtin functions; but there's a small risk of
breaking clients that have chosen to hardwire those function OIDs,
so it's not clear if it'd be worth the trouble.  (We should, however,
discourage future patches from choosing function OIDs above 6K as long
as there's still lots of space below that.)

Discussion: https://postgr.es/m/12359.1547063064@...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8ff5f824dca75174e3d3efc7c1182cf1d388bacc

Modified Files
--------------
src/backend/utils/Gen_fmgrtab.pl | 28 ++++++++++++----------------
src/backend/utils/fmgr/fmgr.c    |  4 ++--
src/include/utils/fmgrtab.h      |  8 +++++---
3 files changed, 19 insertions(+), 21 deletions(-)