pgsql: Repair unsafe/unportable snprintf usage in pg_restore.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Repair unsafe/unportable snprintf usage in pg_restore.

Tom Lane-2
Repair unsafe/unportable snprintf usage in pg_restore.

warn_or_exit_horribly() was blithely passing a potentially-NULL
string pointer to a %s format specifier.  That works (at least
to the extent of not crashing) on some platforms, but not all,
and since we switched to our own snprintf.c it doesn't work
for us anywhere.

Of the three string fields being handled this way here, I think
that only "owner" is supposed to be nullable ... but considering
that this is error-reporting code, it has very little business
assuming anything, so put in defenses for all three.

Per a crash observed on buildfarm member crake and then
reproduced here.  Because of the portability aspect,
back-patch to all supported versions.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4dbe1969079672064777e71c3fc981abbf55e207

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)