pgsql: Switch TAP tests of pg_rewind to use non-superuser role, take tw

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Switch TAP tests of pg_rewind to use non-superuser role, take tw

Michael Paquier-2
Switch TAP tests of pg_rewind to use non-superuser role, take two

Up to now the tests of pg_rewind have been using a superuser for all its
tests (which is the default of many tests actually, and something that
ought to be reviewed) when involving an online source server, still it
is possible to use a non-superuser role to do that as long as this role
is granted permissions to execute all the source-side functions used for
the rewind.  This is possible since v11, and was already documented as
of bfc8068.

PostgresNode::init is extended so as callers of this routine can add
extra options to configure the authentication of a new node, which gets
used by this commit, and allows the tests to work properly on Windows
where SSPI is used.

This will allow to catch up easily any change in pg_rewind if the tool
begins to use more backend-side functions, so as the properties
introduced by v11 are kept.

Per suggestion from Peter Eisentraut.

Author: Michael Paquier
Reviewed-by: Magnus Hagander
Discussion: https://postgr.es/m/20190411041336.GM2728@...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d9f543e9e9be15f92abdeaf870e57ef289020191

Modified Files
--------------
src/bin/pg_rewind/t/RewindTest.pm | 23 ++++++++++++++++++++++-
src/test/perl/PostgresNode.pm     |  3 ++-
2 files changed, 24 insertions(+), 2 deletions(-)