pgsql: pg_collation_actual_version() -> pg_collation_current_version().

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

pgsql: pg_collation_actual_version() -> pg_collation_current_version().

Thomas Munro-4
pg_collation_actual_version() -> pg_collation_current_version().

The new name seems a bit more natural.

Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9cf184cc0599b6e65e7e5ecd9d91cd42e278bcd8

Modified Files
--------------
doc/src/sgml/func.sgml                         |  8 ++++----
src/backend/commands/collationcmds.c           |  2 +-
src/backend/utils/adt/pg_locale.c              | 14 +++++++-------
src/include/catalog/catversion.h               |  2 +-
src/include/catalog/pg_proc.dat                |  4 ++--
src/test/regress/expected/collate.icu.utf8.out |  6 +++---
src/test/regress/sql/collate.icu.utf8.sql      |  6 +++---
7 files changed, 21 insertions(+), 21 deletions(-)

Reply | Threaded
Open this post in threaded view
|

Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().

Peter Eisentraut-3
On 22.02.21 12:28, Thomas Munro wrote:
> pg_collation_actual_version() -> pg_collation_current_version().
>
> The new name seems a bit more natural.
>
> Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com

I don't find where this change was discussed in that thread.  I
specifically chose that name to indicate, "not the current version in
the database, but the version the OS thinks it should be".  I think the
rename loses that distinction.


Reply | Threaded
Open this post in threaded view
|

Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().

Thomas Munro-5
On Tue, Feb 23, 2021 at 7:03 PM Peter Eisentraut <[hidden email]> wrote:

> On 22.02.21 12:28, Thomas Munro wrote:
> > pg_collation_actual_version() -> pg_collation_current_version().
> >
> > The new name seems a bit more natural.
> >
> > Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com
>
> I don't find where this change was discussed in that thread.  I
> specifically chose that name to indicate, "not the current version in
> the database, but the version the OS thinks it should be".  I think the
> rename loses that distinction.

I understood "actual" to be a way of contrasting with
pg_collation.collversion, which we dropped.  Without that, the meaning
of a more typical function name with "current" seemed clearer to me,
and "actual" seemed excessively emphatic.  There isn't a concept of a
single "current version in the database" anymore, there's just the set
of relevant versions that were current when each index was built.
Happy to revert the name change if you hate it though, and sorry I
didn't CC you on the thread.


Reply | Threaded
Open this post in threaded view
|

Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().

Peter Eisentraut-3
On 23.02.21 08:23, Thomas Munro wrote:

> On Tue, Feb 23, 2021 at 7:03 PM Peter Eisentraut <[hidden email]> wrote:
>> On 22.02.21 12:28, Thomas Munro wrote:
>>> pg_collation_actual_version() -> pg_collation_current_version().
>>>
>>> The new name seems a bit more natural.
>>>
>>> Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com
>>
>> I don't find where this change was discussed in that thread.  I
>> specifically chose that name to indicate, "not the current version in
>> the database, but the version the OS thinks it should be".  I think the
>> rename loses that distinction.
>
> I understood "actual" to be a way of contrasting with
> pg_collation.collversion, which we dropped.  Without that, the meaning
> of a more typical function name with "current" seemed clearer to me,
> and "actual" seemed excessively emphatic.  There isn't a concept of a
> single "current version in the database" anymore, there's just the set
> of relevant versions that were current when each index was built.
> Happy to revert the name change if you hate it though, and sorry I
> didn't CC you on the thread.

Seeing that explanation, I think that's even more of a reason to avoid
the name "current" and use something strikingly different.

In any case, this function name has been around for some years now and
renaming it just for taste reasons seems unnecessary.


Reply | Threaded
Open this post in threaded view
|

Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().

Thomas Munro-5
On Thu, Feb 25, 2021 at 10:49 PM Peter Eisentraut <[hidden email]> wrote:
> Seeing that explanation, I think that's even more of a reason to avoid
> the name "current" and use something strikingly different.
>
> In any case, this function name has been around for some years now and
> renaming it just for taste reasons seems unnecessary.

I guess my unspoken assumption was that anyone using this in a query
is probably comparing it with collversion and thus already has a query
that needs to be rewritten for v14, and therefore it's not a bad time
to clean up some naming.  But that argument is moot if you don't even
agree that the new name's an improvement, so... reverted.