pgsql: pg_waldump: Fix --bkp-details to not issue spurious newlines for

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: pg_waldump: Fix --bkp-details to not issue spurious newlines for

Andres Freund
pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.

The additional newline seems to have accidentally been introduced in
2c03216d831, in 9.5. The newline is only issued when an FPW is
present for the block reference.

While there could be an argument that removing the newlines in the
back branches could cause a problem for somebody parsing the
pg_waldump output, the likelihood of that seems small enough. It seems
at least equally likely that the randomness of when newlines are
issued causes problems.

Author: Andres Freund
Discussion: https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@...
Backpatch: 9.5, like 2c03216d831.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e4d92126fda1defd9be201b97b162d1568122064

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)