pgsql: "A void function may not return a value".

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

pgsql: "A void function may not return a value".

Tom Lane-2
"A void function may not return a value".

Per buildfarm.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d307954a7d88ed45655d9206bbe1aefc280c09c7

Modified Files
--------------
src/backend/access/table/tableam.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Reply | Threaded
Open this post in threaded view
|

Re: pgsql: "A void function may not return a value".

Andres Freund
Hi,

On 2019-05-18 04:40:51 +0000, Tom Lane wrote:
> "A void function may not return a value".

Darn.  Thanks.

           For C only, warn about a "return" statement with an expression in a function whose return type is "void", unless the expression type is also
           "void".  As a GNU extension, the latter case is accepted without a warning unless -Wpedantic is used.

And no, no thanks to you gcc. -pedantic is entirely unusable. It warns
about extensions we explicitly test for :(

- Andres


Reply | Threaded
Open this post in threaded view
|

Re: pgsql: "A void function may not return a value".

Tom Lane-2
Andres Freund <[hidden email]> writes:
> On 2019-05-18 04:40:51 +0000, Tom Lane wrote:
>> "A void function may not return a value".

> Darn.  Thanks.

>            For C only, warn about a "return" statement with an expression in a function whose return type is "void", unless the expression type is also
>            "void".  As a GNU extension, the latter case is accepted without a warning unless -Wpedantic is used.

The scary thing is that apparently almost everybody else has followed
gcc's lead on this.

                        regards, tom lane