"Routine Reindexing" docs should be updated to reference REINDEX CONCURRENTLY

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

"Routine Reindexing" docs should be updated to reference REINDEX CONCURRENTLY

Peter Geoghegan-4
The documentation has a section called "Routine Reindexing", which
explains how to simulate REINDEX CONCURRENTLY with a sequence of
creation and replacement steps. This should be updated to reference
the REINDEX CONCURRENTLY command.

--
Peter Geoghegan


Reply | Threaded
Open this post in threaded view
|

Re: "Routine Reindexing" docs should be updated to reference REINDEX CONCURRENTLY

Michael Paquier-2
On Thu, Apr 25, 2019 at 01:34:41PM -0700, Peter Geoghegan wrote:
> The documentation has a section called "Routine Reindexing", which
> explains how to simulate REINDEX CONCURRENTLY with a sequence of
> creation and replacement steps. This should be updated to reference
> the REINDEX CONCURRENTLY command.

Agreed, good catch.  I would suggest to remove most of the section and
just replace it with a reference to REINDEX CONCURRENTLY, as per the
attached.  What do you think?
--
Michael

reindex-docs.patch (1K) Download Attachment
signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: "Routine Reindexing" docs should be updated to reference REINDEX CONCURRENTLY

Peter Eisentraut-6
On 2019-04-26 05:05, Michael Paquier wrote:
> On Thu, Apr 25, 2019 at 01:34:41PM -0700, Peter Geoghegan wrote:
>> The documentation has a section called "Routine Reindexing", which
>> explains how to simulate REINDEX CONCURRENTLY with a sequence of
>> creation and replacement steps. This should be updated to reference
>> the REINDEX CONCURRENTLY command.
>
> Agreed, good catch.  I would suggest to remove most of the section and
> just replace it with a reference to REINDEX CONCURRENTLY, as per the
> attached.  What do you think?

looks good to me

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Reply | Threaded
Open this post in threaded view
|

Re: "Routine Reindexing" docs should be updated to reference REINDEX CONCURRENTLY

Tom Lane-2
In reply to this post by Michael Paquier-2
Michael Paquier <[hidden email]> writes:
> On Thu, Apr 25, 2019 at 01:34:41PM -0700, Peter Geoghegan wrote:
>> The documentation has a section called "Routine Reindexing", which
>> explains how to simulate REINDEX CONCURRENTLY with a sequence of
>> creation and replacement steps. This should be updated to reference
>> the REINDEX CONCURRENTLY command.

> Agreed, good catch.  I would suggest to remove most of the section and
> just replace it with a reference to REINDEX CONCURRENTLY, as per the
> attached.  What do you think?

+1.  Maybe say "... which requires only a
<literal>SHARE UPDATE EXCLUSIVE</literal> lock."

                        regards, tom lane


Reply | Threaded
Open this post in threaded view
|

Re: "Routine Reindexing" docs should be updated to reference REINDEX CONCURRENTLY

Michael Paquier-2
On Fri, Apr 26, 2019 at 10:53:35AM -0400, Tom Lane wrote:
> +1.  Maybe say "... which requires only a
> <literal>SHARE UPDATE EXCLUSIVE</literal> lock."

Thanks for the review.  Committed with your suggested change.
--
Michael

signature.asc (849 bytes) Download Attachment