rewrite ExecPartitionCheckEmitError

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

rewrite ExecPartitionCheckEmitError

Alvaro Herrera-9
Just on cleanliness grounds, I propose to rewrite the function in
$SUBJECT.  I came across this while reviewing some already-committed
patch for partition pruning, and it's been sitting in my laptop ever
since.

I think the current coding is too convoluted and hard to follow.  The
patch makes it much simpler (IMO).

--
Álvaro Herrera

0001-rewrite-ExecPartitionCheckEmitError.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: rewrite ExecPartitionCheckEmitError

Robert Haas
On Thu, Dec 6, 2018 at 5:22 PM Alvaro Herrera <[hidden email]> wrote:
> Just on cleanliness grounds, I propose to rewrite the function in
> $SUBJECT.  I came across this while reviewing some already-committed
> patch for partition pruning, and it's been sitting in my laptop ever
> since.
>
> I think the current coding is too convoluted and hard to follow.  The
> patch makes it much simpler (IMO).

I don't really think this is an improvement, but the only part I
really dislike is s/val_desc/valdsc/.  That is surely not an
improvement in readability.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Reply | Threaded
Open this post in threaded view
|

Re: rewrite ExecPartitionCheckEmitError

Alvaro Herrera-9
On 2018-Dec-07, Robert Haas wrote:

> On Thu, Dec 6, 2018 at 5:22 PM Alvaro Herrera <[hidden email]> wrote:
> > Just on cleanliness grounds, I propose to rewrite the function in
> > $SUBJECT.  I came across this while reviewing some already-committed
> > patch for partition pruning, and it's been sitting in my laptop ever
> > since.
> >
> > I think the current coding is too convoluted and hard to follow.  The
> > patch makes it much simpler (IMO).
>
> I don't really think this is an improvement, but the only part I
> really dislike is s/val_desc/valdsc/.  That is surely not an
> improvement in readability.

Point taken; pushed with that change.

--
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Reply | Threaded
Open this post in threaded view
|

Re: rewrite ExecPartitionCheckEmitError

David Rowley-3
On Sat, 29 Dec 2018 at 06:52, Alvaro Herrera <[hidden email]> wrote:
> Point taken; pushed with that change.

Marking this as committed in the CF app.

--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services