with oids option not removed in pg_dumpall

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

with oids option not removed in pg_dumpall

Surafel Temesgen
Hello,
Commit 578b229718e8f remove oids option from pg_dump but its is
still in pg_dumpall .The attach patch remove it
regards
Surafel

remove-oids-option-pg_dumpall.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: with oids option not removed in pg_dumpall

Michael Paquier-2
On Tue, May 21, 2019 at 09:31:48AM +0300, Surafel Temesgen wrote:
> Commit 578b229718e8f remove oids option from pg_dump but its is
> still in pg_dumpall .The attach patch remove it

Good catch.  Your cleanup looks correct to me.  Andres, perhaps you
would prefer doing the cleanup yourself?
--
Michael

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: with oids option not removed in pg_dumpall

Michael Paquier-2
On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote:
> Good catch.  Your cleanup looks correct to me.  Andres, perhaps you
> would prefer doing the cleanup yourself?

As I am cleaning up the area for another issue, applied.
--
Michael

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: with oids option not removed in pg_dumpall

Surafel Temesgen
Thank you for applying

regards
Surafel

On Thu, May 23, 2019 at 3:43 AM Michael Paquier <[hidden email]> wrote:
On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote:
> Good catch.  Your cleanup looks correct to me.  Andres, perhaps you
> would prefer doing the cleanup yourself?

As I am cleaning up the area for another issue, applied.
--
Michael
Reply | Threaded
Open this post in threaded view
|

Re: with oids option not removed in pg_dumpall

Andres Freund
Hi,

On 2019-05-23 16:26:38 +0300, Surafel Temesgen wrote:

> Thank you for applying
>
> regards
> Surafel
>
> On Thu, May 23, 2019 at 3:43 AM Michael Paquier <[hidden email]> wrote:
>
> > On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote:
> > > Good catch.  Your cleanup looks correct to me.  Andres, perhaps you
> > > would prefer doing the cleanup yourself?
> >
> > As I am cleaning up the area for another issue, applied.

Thanks for finding and applying.

Greetings,

Andres Freund